Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: add saga io.seata compatible api #6312

Merged
merged 3 commits into from
Jan 30, 2024
Merged

optimize: add saga io.seata compatible api #6312

merged 3 commits into from
Jan 30, 2024

Conversation

ptyin
Copy link
Member

@ptyin ptyin commented Jan 28, 2024 •
edited by xingfudeshi
Loading

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Add Saga related API to compatible module. The basic idea is to use wrapper pattern to wrap actual implementation (org.apache.seata). For all implementation classes, I added two methods, i.e., wrap org.apache.seata to io.seata and unwrap org.apache.seata from io.seata.

Ⅱ. Does this pull request fix one issue?

Related to #6059

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16689ad) 51.98% compared to head (8154fe6) 51.99%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #6312   +/-   ##
=========================================
  Coverage     51.98%   51.99%           
  Complexity     5173     5173           
=========================================
  Files           918      918           
  Lines         32039    32039           
  Branches       3866     3866           
=========================================
+ Hits          16656    16659    +3     
+ Misses        13758    13754    -4     
- Partials       1625     1626    +1

see 6 files with indirect coverage changes

@xingfudeshi
Copy link
Member

Please register this PR in CHANGES

@wt-better
Copy link
Contributor

io.seata.saga.engine.repo.StateMachineRepository also need .

@xingfudeshi
Copy link
Member

io.seata.saga.engine.repo.StateMachineRepository also need .

I suggest merging this PR first. I will submit an SPI compatible PR later.

@ptyin
Copy link
Member Author

ptyin commented Jan 30, 2024

io.seata.saga.engine.repo.StateMachineRepository also need .

I suggest merging this PR first. I will submit an SPI compatible PR later.

If so, I will suplement Saga component-level API in another PR.

@xingfudeshi
Copy link
Member

io.seata.saga.engine.repo.StateMachineRepository also need .

I suggest merging this PR first. I will submit an SPI compatible PR later.

If so, I will suplement Saga component-level API in another PR.

Ok,you can review my PR and see if there is anything else that needs to be added.

xingfudeshi
xingfudeshi approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 74785d2 into apache:2.x Jan 30, 2024
6 checks passed
@slievrly slievrly added this to the 2.1.0 milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xingfudeshi xingfudeshi xingfudeshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ptyin @codecov-commenter @xingfudeshi @wt-better @slievrly